Re: [PATCH v2 08/12] python: Fix .PHONY Make specifiers

[Wainer dos Santos Moschetta]

On 6/29/21 1:42 PM, John Snow wrote:
> I missed the 'check-tox' target. Add that, but split the large .PHONY
> specifier at the top into its component pieces and move them near the
> targets they describe so that they're much harder to forget to update.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   python/Makefile | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)

I didn't know .PHONY could be split. Nice!

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

> diff --git a/python/Makefile b/python/Makefile
> index d2cfa6ad8f..d34c4e35d9 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -1,5 +1,4 @@
> -.PHONY: help pipenv check-pipenv check clean distclean develop
> -
> +.PHONY: help
>   help:
>         @echo "python packaging help:"
>         @echo ""
> @@ -29,25 +28,32 @@ help:
>         @echo "                 built distribution files, and everything"
>         @echo "                 from 'make clean'."
>   
> +.PHONY: pipenv
>   pipenv: .venv
>   .venv: Pipfile.lock
>         @PIPENV_VENV_IN_PROJECT=1 pipenv sync --dev --keep-outdated
>         @touch .venv
>   
> +.PHONY: check-pipenv
>   check-pipenv: pipenv
>         @pipenv run make check
>   
> +.PHONY: develop
>   develop:
>         pip3 install -e .[devel]
>   
> +.PHONY: check
>   check:
>         @avocado --config avocado.cfg run tests/
>   
> +.PHONY: check-tox
>   check-tox:
>         @tox
>   
> +.PHONY: clean
>   clean:
>         python3 setup.py clean --all
>   
> +.PHONY: distclean
>   distclean: clean
>         rm -rf qemu.egg-info/ .venv/ .tox/ dist/