On 6/25/21 12:45 PM, John Snow wrote:
> This is a *third* way to run the Python tests. Unlike the first two
> (check-pipenv, check-tox), this version does not require any specific
> interpreter version -- making it a lot easier to tell people to run it
> as a quick smoketest prior to submission to GitLab CI.
>
> Summary:
>
> Checked via GitLab CI:
> - check-pipenv: tests our oldest python & dependencies
> - check-tox: tests newest dependencies on all non-EOL python versions
> Executed only incidentally:
> - check-venv: tests newest dependencies on whichever python version
>
> ('make check' does not set up any environment at all, it just runs the
> tests in your current environment. All four invocations perform the
> exact same tests, just in different execution environments.)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/Makefile | 35 ++++++++++++++++++++++++++++++++---
> 1 file changed, 32 insertions(+), 3 deletions(-)
>
> diff --git a/python/Makefile b/python/Makefile
> index 5cb8378b81..76bb24e671 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -1,4 +1,6 @@
> -.PHONY: help pipenv check-pipenv check clean distclean develop
> +.PHONY: help pipenv venv check-venv check-pipenv check clean distclean develop
> +
btw, check-tox is missed here ^
Oops, thanks! I am not sure it winds up mattering, but writing Makefiles feels like religion. I just follow the same steps and pray at the altar.
> +QEMU_VENV_DIR=~/.cache/qemu-pyvenv
A few suggestions:
1. For the sake of consistence with others temporary directories
created, use QEMU_VENV_DIR=<path-to-qemu-src>/.devvenv
Sure, straight in this folder, like .tox and .venv you mean?
(I'd rename .venv to .pipenv, but pipenv doesn't let you name this folder, annoyingly ...)
2. Reword to 'devvenv' or 'dev-venv' (or something similar), instead of
'venv', the directories and Make targets. IMHO it will make the purpose
of the targets a bit clear.
Sure, I'll do that -- .dev-venv works for me.
What do you think John?
I think that it's hot outside :)
- Wainer
Thanks!
--js