Re: [PATCH 2/3] hw/char: renesas_sci Add SCI and SCIF support.

[Peter Maydell]

On Wed, 16 Jun 2021 at 10:20, Yoshinori Sato <ysato@users.sourceforge.jp> wrote:
>
> This peripheral using SH7750.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>  include/hw/char/renesas_sci.h |  43 ++-
>  hw/char/renesas_sci.c         | 489 ++++++++++++++++++++++++++++++++++
>  2 files changed, 531 insertions(+), 1 deletion(-)

>  enum {
>      ERI = 0,
> @@ -32,6 +38,7 @@ enum {
>  };
>
>  enum {
> +    RXTOUT,
>      RXNEXT,
>      TXEMPTY,
>      TXEND,
> @@ -49,13 +56,14 @@ typedef struct RenesasSCIBaseState {
>      SysBusDevice parent_obj;
>
>      MemoryRegion memory;
> +    MemoryRegion memory_p4;
> +    MemoryRegion memory_a7;
>      QEMUTimer *event_timer;
>
>      /*< public >*/
>      uint64_t input_freq;
>      int64_t etu;
>      int64_t trtime;
> -    int64_t tx_start_time;

It looks like you added this field in patch 1, where it wasn't used,
and then deleted it again in patch 2...

thanks
-- PMM