[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers |
Date: |
Mon, 28 Jun 2021 18:33:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Hi Richard,
On 6/19/21 2:41 PM, Richard Henderson wrote:
> On 6/19/21 2:26 AM, Philippe Mathieu-Daudé wrote:
>>> It doesn't seem to match the next
>>> two patches, which don't create new compilation units.
>>
>> Indeed. In a yet-to-be-posted later series they get renamed to .c,
>> becoming new units.
>
> Ah, ok.
>
>> What I can do is hold these patches and post them later with the
>> yet-to-be-posted series, *but* that breaks the "extract nanomips
>> from translate.c" which you already reviewed :/
>
> I don't mind the ordering, just that there's a reason.
Is that OK if I reword as:
---
We want to extract the microMIPS ISA and Code Compaction ASE to
new compilation units.
We will first extract this code as included source files (.c.inc),
then make them new compilation units afterward.
The following methods are going to be used externally:
micromips_translate.c.inc:1778: gen_ldxs(ctx, rs, rt, rd);
micromips_translate.c.inc:1806: gen_align(ctx, 32, rd, rs, ...
micromips_translate.c.inc:2859: gen_addiupc(ctx, reg, offset, ...
mips16e_translate.c.inc:444: gen_addiupc(ctx, ry, offset, ...
To avoid too much code churn, it is simpler to declare these
prototypes in "translate.h" now.
---
?
[PATCH 2/4] target/mips: Extract Code Compaction ASE translation routines, Philippe Mathieu-Daudé, 2021/06/17
[PATCH 4/4] target/mips: Add declarations for generic DSP TCG helpers, Philippe Mathieu-Daudé, 2021/06/17
[PATCH 3/4] target/mips: Extract the microMIPS ISA translation routines, Philippe Mathieu-Daudé, 2021/06/17
Re: [PATCH 0/4] target/mips: Extract microMIPS ISA and Code Compaction ASE apart, Philippe Mathieu-Daudé, 2021/06/29