Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

[Alexander Graf]

On 28.06.21 13:28, Dr. David Alan Gilbert wrote:
> * Alexander Graf (agraf@csgraf.de) wrote:
>> On 14.06.21 13:57, Dr. David Alan Gilbert wrote:
>>> cc'ing in qemu-stable - I think we'd probably want this on 6.0
>>> (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ).
>>> Although you'll probably also want the missing dependency fix
>>> Philippe is working (See: 
>>> Mathieu- ( 42) [RFC PATCH] migration: Add missing dependency on GNUTLS )
>>
>> Current master does not compile for me anymore (on macOS) due to this
>> change. Can we please either disable yank support and revert this patch,
>> pick the GNUTLS dependency patch you refer to quickly and work on a real
>> fix afterwards or get the proposed fix in the "missing dependency on
>> GNUTLS" discussion done quickly?
>>
>> Having a broken tree is going to make bisection super painful later.
> There was Phil's dependency fix;
> https://lore.kernel.org/qemu-devel/YMcTpO2SlVSc%2FHCR@redhat.com/t/
>
> but there still seemed to be some argument if this was the right way to
> do it.


Perfect is the enemy of good :). Can we please fix the tree first, then
do "the right way"? I agree that not relying on the GNUTLS header in
that file is sensible, but it's been almost 2 weeks since that simple
one-liner, working fix was posted without anyone following up with a
more complete solution.


Alex