[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/28] file-posix: fix max_iov for /dev/sg devices
From: |
Paolo Bonzini |
Subject: |
[PULL 13/28] file-posix: fix max_iov for /dev/sg devices |
Date: |
Fri, 25 Jun 2021 16:18:07 +0200 |
Even though it was only called for devices that have bs->sg set (which
must be character devices), sg_get_max_segments looked at /sys/dev/block
which only works for block devices.
On Linux the sg driver has its own way to provide the maximum number of
iovecs in a scatter/gather list, so add support for it. The block device
path is kept because it will be reinstated in the next patches.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
block/file-posix.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index b3fbb9bd63..b8dc19ce1a 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1178,6 +1178,17 @@ static int sg_get_max_segments(int fd)
goto out;
}
+ if (S_ISCHR(st.st_mode)) {
+ if (ioctl(fd, SG_GET_SG_TABLESIZE, &ret) == 0) {
+ return ret;
+ }
+ return -ENOTSUP;
+ }
+
+ if (!S_ISBLK(st.st_mode)) {
+ return -ENOTSUP;
+ }
+
sysfspath = g_strdup_printf("/sys/dev/block/%u:%u/queue/max_segments",
major(st.st_rdev), minor(st.st_rdev));
sysfd = open(sysfspath, O_RDONLY);
--
2.31.1
- [PULL 02/28] meson: drop unused CONFIG_GCRYPT_HMAC, (continued)
- [PULL 02/28] meson: drop unused CONFIG_GCRYPT_HMAC, Paolo Bonzini, 2021/06/25
- [PULL 04/28] meson: remove preadv from summary, Paolo Bonzini, 2021/06/25
- [PULL 06/28] configure, meson: convert crypto detection to meson, Paolo Bonzini, 2021/06/25
- [PULL 09/28] configure, meson: convert libusb detection to meson, Paolo Bonzini, 2021/06/25
- [PULL 05/28] tests: remove QCRYPTO_HAVE_TLS_TEST_SUPPORT, Paolo Bonzini, 2021/06/25
- [PULL 08/28] configure, meson: convert pam detection to meson, Paolo Bonzini, 2021/06/25
- [PULL 10/28] configure, meson: convert libcacard detection to meson, Paolo Bonzini, 2021/06/25
- [PULL 11/28] configure, meson: convert libusbredir detection to meson, Paolo Bonzini, 2021/06/25
- [PULL 07/28] configure, meson: convert libtasn1 detection to meson, Paolo Bonzini, 2021/06/25
- [PULL 12/28] KVM: Fix dirty ring mmap incorrect size due to renaming accident, Paolo Bonzini, 2021/06/25
- [PULL 13/28] file-posix: fix max_iov for /dev/sg devices,
Paolo Bonzini <=
- [PULL 14/28] scsi-generic: pass max_segments via max_iov field in BlockLimits, Paolo Bonzini, 2021/06/25
- [PULL 16/28] block-backend: align max_transfer to request alignment, Paolo Bonzini, 2021/06/25
- [PULL 15/28] osdep: provide ROUND_DOWN macro, Paolo Bonzini, 2021/06/25
- [PULL 17/28] block: add max_hw_transfer to BlockLimits, Paolo Bonzini, 2021/06/25
- [PULL 18/28] file-posix: try BLKSECTGET on block devices too, do not round to power of 2, Paolo Bonzini, 2021/06/25
- [PULL 19/28] block: feature detection for host block support, Paolo Bonzini, 2021/06/25
- [PULL 21/28] block: try BSD disk size ioctls one after another, Paolo Bonzini, 2021/06/25
- [PULL 20/28] block: check for sys/disk.h, Paolo Bonzini, 2021/06/25
- [PULL 22/28] block: detect DKIOCGETBLOCKCOUNT/SIZE before use, Paolo Bonzini, 2021/06/25