Re: [PULL 00/12] Misc, mostly meson patches for 2021-06-23

[Paolo Bonzini]

On 25/06/21 10:09, Peter Maydell wrote:
> Looks like a missing #include <stddef.h> in the test code, rather
> than anything specifically libpam related.

Yes, indeed.

> More generally, I think if meson probes for some library
> and can't find it, the correct response is that it should
> just print "Library libpam found: NO", not a "WARNING".
> "You don't have an optional library, we'll skip that optional
> feature" is a normal situation.

The "NO" is present in the final summary; having the library but then 
failing to compile something is a relatively common case when you cannot 
filter by version using pkg-config.  But indeed we can downgrade those 
warnings to message().

Paolo