Re: [PATCH v2 1/6] tests/acceptance: add replay kernel test for s390

[Thomas Huth]

On 25/06/2021 07.39, Pavel Dovgalyuk wrote:
> This patch adds record/replay test which boots Linux
> kernel on s390x platform. The test uses kernel binaries
> taken from boot_linux_console test.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> ---
>   tests/acceptance/replay_kernel.py |   16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/tests/acceptance/replay_kernel.py 
> b/tests/acceptance/replay_kernel.py
> index 71facdaa75..cdc22cb6d3 100644
> --- a/tests/acceptance/replay_kernel.py
> +++ b/tests/acceptance/replay_kernel.py
> @@ -208,6 +208,22 @@ def test_arm_cubieboard_initrd(self):
>                             '-initrd', initrd_path,
>                             '-no-reboot'))
>   
> +    def test_s390x_s390_ccw_virtio(self):
> +        """
> +        :avocado: tags=arch:s390x
> +        :avocado: tags=machine:s390-ccw-virtio
> +        """
> +        kernel_url = ('https://archives.fedoraproject.org/pub/archive'
> +                      
> '/fedora-secondary/releases/29/Everything/s390x/os/images'
> +                      '/kernel.img')
> +        kernel_hash = 'e8e8439103ef8053418ef062644ffd46a7919313'
> +        kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
> +
> +        kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=sclp0'
> +        console_pattern = 'Kernel command line: %s' % kernel_command_line
> +        self.run_rr(kernel_path, kernel_command_line, console_pattern, shift=9,
> +            args=('-nodefaults', '-smp', '1'))

I guess you could drop the "-smp 1" since one CPU is the default anyway.

Anyway,
Acked-by: Thomas Huth <thuth@redhat.com>