Re: [PULL 0/2] Audio 20210624 patches

[no-reply]

Patchew URL: 
20210624121639.2422367-1-kraxel@redhat.com/">https://patchew.org/QEMU/20210624121639.2422367-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210624121639.2422367-1-kraxel@redhat.com
Subject: [PULL 0/2] Audio 20210624 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210624121639.2422367-1-kraxel@redhat.com -> 
patchew/20210624121639.2422367-1-kraxel@redhat.com
Switched to a new branch 'test'
b397205 hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h
8b66bf4 coreaudio: Lock only the buffer

=== OUTPUT BEGIN ===
1/2 Checking commit 8b66bf451269 (coreaudio: Lock only the buffer)
ERROR: space prohibited between function name and open parenthesis '('
#61: FILE: audio/coreaudio.c:245:
+static int coreaudio_buf_lock (coreaudioVoiceOut *core, const char *fn_name)

ERROR: space prohibited between function name and open parenthesis '('
#66: FILE: audio/coreaudio.c:249:
+    err = pthread_mutex_lock (&core->buf_mutex);

ERROR: space prohibited between function name and open parenthesis '('
#75: FILE: audio/coreaudio.c:258:
+static int coreaudio_buf_unlock (coreaudioVoiceOut *core, const char *fn_name)

ERROR: space prohibited between function name and open parenthesis '('
#80: FILE: audio/coreaudio.c:262:
+    err = pthread_mutex_unlock (&core->buf_mutex);

ERROR: space prohibited between function name and open parenthesis '('
#117: FILE: audio/coreaudio.c:314:
+    if (coreaudio_buf_lock (core, "audioDeviceIOProc")) {

ERROR: space prohibited between function name and open parenthesis '('
#124: FILE: audio/coreaudio.c:320:
+        coreaudio_buf_unlock (core, "audioDeviceIOProc(old device)");

ERROR: space prohibited between function name and open parenthesis '('
#133: FILE: audio/coreaudio.c:330:
+        coreaudio_buf_unlock (core, "audioDeviceIOProc(empty)");

ERROR: space prohibited between function name and open parenthesis '('
#142: FILE: audio/coreaudio.c:352:
+    coreaudio_buf_unlock (core, "audioDeviceIOProc");

total: 8 errors, 0 warnings, 237 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit b39720569bf6 (hw/audio/sb16: Restrict I/O sampling rate 
range for command 41h/42h)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210624121639.2422367-1-kraxel@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210624121639.2422367-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com