[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 3/5] ui: Create sync objects and fences only for blobs
From: |
Kasireddy, Vivek |
Subject: |
RE: [PATCH v3 3/5] ui: Create sync objects and fences only for blobs |
Date: |
Wed, 23 Jun 2021 19:11:17 +0000 |
Hi Gerd,
> Hi,
>
> > dmabuf->buf.fd = res->dmabuf_fd;
> > + dmabuf->buf.blob = true;
>
> Do you actually need the 'blob' field?
> I think checking 'fd' instead should work too.
[Kasireddy, Vivek] I want these changes to be limited to blob resources only as
I do not
know how they might affect other use-cases or whether they are needed there or
not. I
don't think I can rely on fd as vfio/display.c also populates the fd field:
dmabuf = g_new0(VFIODMABuf, 1);
dmabuf->dmabuf_id = plane.dmabuf_id;
dmabuf->buf.width = plane.width;
dmabuf->buf.height = plane.height;
dmabuf->buf.stride = plane.stride;
dmabuf->buf.fourcc = plane.drm_format;
dmabuf->buf.modifier = plane.drm_format_mod;
dmabuf->buf.fd = fd;
Therefore, I need a way to identify a dmabuf that is associated with blobs vs
others.
Thanks,
Vivek
- [PATCH v3 0/5] virtio-gpu: Add a default synchronization mechanism for blobs, Vivek Kasireddy, 2021/06/21
- [PATCH v3 4/5] ui/gtk-egl: Wait for the draw signal for dmabuf blobs, Vivek Kasireddy, 2021/06/21
- [PATCH v3 1/5] ui/gtk: Create a common release_dmabuf helper, Vivek Kasireddy, 2021/06/21
- [PATCH v3 5/5] virtio-gpu: Add gl_flushed callback, Vivek Kasireddy, 2021/06/21
- [PATCH v3 2/5] ui/egl: Add egl helpers to help with synchronization, Vivek Kasireddy, 2021/06/21
- [PATCH v3 3/5] ui: Create sync objects and fences only for blobs, Vivek Kasireddy, 2021/06/21
Re: [PATCH v3 0/5] virtio-gpu: Add a default synchronization mechanism for blobs, no-reply, 2021/06/21