|
| From: | Alex Bennée |
| Subject: | Re: [PATCH v2 1/2] contrib/plugins: add execlog to log instruction execution and memory access |
| Date: | Tue, 22 Jun 2021 11:33:11 +0100 |
| User-agent: | mu4e 1.5.13; emacs 28.0.50 |
Alexandre IOOSS <erdnaxe@crans.org> writes: > [[PGP Signed Part:Undecided]] > On 6/22/21 10:37 AM, Alex Bennée wrote: >> We only allocate last_exec for system.max_vcpus here. You need to check >> the system_emulation bool before using that information and error out if >> it's not system emulation. > > My bad, I did not test user mode emulation after converting last_exec > to an array. Should I consider only one vCPU in user mode emulation? It's up to you. The cpuid is essentially unbounded for linux-user so you could either dynamically assign new entries as they come up or just not load for non system emulation cases. If you attempt to run multi-threaded programs with a single entry in the array you will get weird interleaving issues. > > -- Alexandre > > [[End of PGP Signed Part]] -- Alex Bennée
| [Prev in Thread] | Current Thread | [Next in Thread] |