[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 26/29] target/mips: Fix gen_mxu_s32ldd_s32lddr
From: |
Richard Henderson |
Subject: |
[PATCH v2 26/29] target/mips: Fix gen_mxu_s32ldd_s32lddr |
Date: |
Mon, 21 Jun 2021 16:18:46 -0700 |
There were two bugs here: (1) the required endianness was
not present in the MemOp, and (2) we were not providing a
zero-extended input to the bswap as semantics required.
The best fix is to fold the bswap into the memory operation,
producing the desired result directly.
Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/mips/tcg/mxu_translate.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/target/mips/tcg/mxu_translate.c b/target/mips/tcg/mxu_translate.c
index c12cf78df7..f4356432c7 100644
--- a/target/mips/tcg/mxu_translate.c
+++ b/target/mips/tcg/mxu_translate.c
@@ -857,12 +857,8 @@ static void gen_mxu_s32ldd_s32lddr(DisasContext *ctx)
tcg_gen_ori_tl(t1, t1, 0xFFFFF000);
}
tcg_gen_add_tl(t1, t0, t1);
- tcg_gen_qemu_ld_tl(t1, t1, ctx->mem_idx, MO_SL);
+ tcg_gen_qemu_ld_tl(t1, t1, ctx->mem_idx, MO_TESL ^ (sel * MO_BSWAP));
- if (sel == 1) {
- /* S32LDDR */
- tcg_gen_bswap32_tl(t1, t1, TCG_BSWAP_IZ | TCG_BSWAP_OZ);
- }
gen_store_mxu_gpr(t1, XRa);
tcg_temp_free(t0);
--
2.25.1
- [PATCH v2 22/29] target/arm: Improve vector REV, (continued)
- [PATCH v2 22/29] target/arm: Improve vector REV, Richard Henderson, 2021/06/21
- [PATCH v2 24/29] target/i386: Improve bswap translation, Richard Henderson, 2021/06/21
- [PATCH v2 19/29] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*, Richard Henderson, 2021/06/21
- [PATCH v2 20/29] tcg: Make use of bswap flags in tcg_gen_qemu_st_*, Richard Henderson, 2021/06/21
- [PATCH v2 18/29] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64, Richard Henderson, 2021/06/21
- [PATCH v2 25/29] target/sh4: Improve swap.b translation, Richard Henderson, 2021/06/21
- [PATCH v2 21/29] target/arm: Improve REV32, Richard Henderson, 2021/06/21
- [PATCH v2 23/29] target/arm: Improve REVSH, Richard Henderson, 2021/06/21
- [PATCH v2 26/29] target/mips: Fix gen_mxu_s32ldd_s32lddr,
Richard Henderson <=
- [PATCH v2 28/29] tcg/aarch64: Unset TCG_TARGET_HAS_MEMORY_BSWAP, Richard Henderson, 2021/06/21
- [PATCH v2 29/29] tcg/riscv: Remove MO_BSWAP handling, Richard Henderson, 2021/06/21
- [PATCH v2 27/29] tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP, Richard Henderson, 2021/06/21
- Re: [PATCH v2 00/29] tcg: bswap improvements, no-reply, 2021/06/21