[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] block/nbd: Do not force-cap *pnum
From: |
Eric Blake |
Subject: |
Re: [PATCH 5/6] block/nbd: Do not force-cap *pnum |
Date: |
Mon, 21 Jun 2021 13:54:18 -0500 |
User-agent: |
NeoMutt/20210205 |
On Mon, Jun 21, 2021 at 11:50:02AM +0200, Max Reitz wrote:
> > I don't that this change is correct. In contrast with file-posix you
> > don't get extra information for free, you just make a larger request.
> > This means that server will have to do more work.
>
> Oh, oops. Seems I was blind in my rage to replace this MIN() pattern.
>
> You’re absolutely right. So this patch should be dropped.
I disagree - I think ths patch is still correct, as written, _because_
we use the REQ_ONE flag.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 3/6] block/file-posix: Do not force-cap *pnum, (continued)
[PATCH 6/6] block/iscsi: Do not force-cap *pnum, Max Reitz, 2021/06/17