Re: [PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

[no-reply]

Patchew URL: 
20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com/">https://patchew.org/QEMU/20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com
Subject: [PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210526142438.281477-1-f4bug@amsat.org -> 
patchew/20210526142438.281477-1-f4bug@amsat.org
 - [tag update]      
patchew/20210614083800.1166166-1-richard.henderson@linaro.org -> 
patchew/20210614083800.1166166-1-richard.henderson@linaro.org
 * [new tag]         
patchew/20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com -> 
patchew/20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com
Switched to a new branch 'test'
c6b3ba6 tests/tcg: Test that compare-and-trap raises SIGFPE
7bab442 linux-user/s390x: signal with SIGFPE on compare-and-trap

=== OUTPUT BEGIN ===
1/2 Checking commit 7bab4427a5e9 (linux-user/s390x: signal with SIGFPE on 
compare-and-trap)
2/2 Checking commit c6b3ba625805 (tests/tcg: Test that compare-and-trap raises 
SIGFPE)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

ERROR: do not initialise globals to 0 or NULL
#71: FILE: tests/tcg/s390x/trap.c:42:
+int sigfpe_count = 0;

ERROR: do not initialise globals to 0 or NULL
#72: FILE: tests/tcg/s390x/trap.c:43:
+int sigill_count = 0;

ERROR: trailing whitespace
#83: FILE: tests/tcg/s390x/trap.c:54:
+    $

ERROR: trailing whitespace
#116: FILE: tests/tcg/s390x/trap.c:87:
+        : $

total: 4 errors, 1 warnings, 104 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com