RE: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

[Khor, Swee Aun]

Hi Gerg and Markus,

Hmm, right, nothing obvious at 
https://developer.gnome.org/gtk3/stable/GtkWindow.html for the non-full-screen 
case.

Nevertheless the options should have sane semantics.  We could:

  (1) Require full-screen=on in addition to monitor=<nr>.
      That would leave the door open to implement the full-screen=off
      case later if we figure some way to do that.
  (2) Rename the option to full-screen-on-monitor, to make clear this
      automatically enables fullscreen too.

sweeaun:  Alright, I would opt for option 2 in this case. Thanks for the 
feedback from you and Markus , I shall rework all the feedbacks for the v3.   

Regards,
SweeAun

-----Original Message-----
From: Gerd Hoffmann <kraxel@redhat.com> 
Sent: Monday, June 21, 2021 7:15 PM
To: Khor, Swee Aun <swee.aun.khor@intel.com>
Cc: Romli, Khairul Anuar <khairul.anuar.romli@intel.com>; Kasireddy, Vivek 
<vivek.kasireddy@intel.com>; eblake@redhat.com; Markus Armbruster 
<armbru@redhat.com>; qemu-devel@nongnu.org
Subject: Re: [PATCH v2] ui/gtk: Allow user to select monitor number to display 
qemu in full screen through new gtk display option

  Hi,

> Well, wouldn't it make sense to have monitor=<nr> work for both 
> full-screen=on and full-screen=off cases?
> sweeaun:  Yes. That will be better option for user. However, I not managed to 
> find other GTK window API that can set window into monitor rather than 
> gtk_window_fullscreen_on_monitor so far.    

Hmm, right, nothing obvious at 
https://developer.gnome.org/gtk3/stable/GtkWindow.html for the non-full-screen 
case.

Nevertheless the options should have sane semantics.  We could:

  (1) Require full-screen=on in addition to monitor=<nr>.
      That would leave the door open to implement the full-screen=off
      case later if we figure some way to do that.
  (2) Rename the option to full-screen-on-monitor, to make clear this
      automatically enables fullscreen too.

take care,
  Gerd