[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl
From: |
Catalin Marinas |
Subject: |
Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl |
Date: |
Mon, 21 Jun 2021 09:48:07 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Jun 21, 2021 at 09:18:31AM +0100, Steven Price wrote:
> On 18/06/2021 15:52, Catalin Marinas wrote:
> > On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote:
> >> +When this capability is enabled all memory in (non-device) memslots must
> >> not
> >> +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will
> >> result
> >> +in an -EINVAL return.
> >
> > "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as
> > that's a kernel internal and not something the VMM needs to be aware of.
> > Just say something like "memslots must be mapped as shareable
> > (MAP_SHARED)".
>
> I think I meant "must not use" - and indeed memslots must *not* be
> mapped as shareable. I'll update to this wording:
>
> When this capability is enabled all memory in memslots must be mapped as
> not-shareable (no MAP_SHARED), attempts to create a memslot with MAP_SHARED
> will result in an -EINVAL return.
It looks fine. Feel free to keep my reviewed-by.
--
Catalin
- [PATCH v16 3/7] KVM: arm64: Introduce MTE VM feature, (continued)
- [PATCH v16 3/7] KVM: arm64: Introduce MTE VM feature, Steven Price, 2021/06/18
- [PATCH v16 4/7] KVM: arm64: Save/restore MTE registers, Steven Price, 2021/06/18
- [PATCH v16 5/7] KVM: arm64: Expose KVM_ARM_CAP_MTE, Steven Price, 2021/06/18
- [PATCH v16 6/7] KVM: arm64: ioctl to fetch/store tags in a guest, Steven Price, 2021/06/18
- [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl, Steven Price, 2021/06/18