[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 04/18] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add
From: |
Jason Wang |
Subject: |
[PATCH 04/18] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add() |
Date: |
Mon, 21 Jun 2021 12:16:36 +0800 |
The VhostVDPAState is just allocated by qemu_new_net_client() via
g_malloc0() in net_vhost_vdpa_init(). So s->vhost_net is NULL for
sure, let's remove this unnecessary check in vhost_vdpa_add().
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/vhost-vdpa.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 18b45ad777..728e63ff54 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -112,10 +112,6 @@ static int vhost_vdpa_add(NetClientState *ncs, void *be)
error_report("failed to init vhost_net for queue");
goto err;
}
- if (s->vhost_net) {
- vhost_net_cleanup(s->vhost_net);
- g_free(s->vhost_net);
- }
s->vhost_net = net;
ret = vhost_vdpa_net_check_device_id(net);
if (ret) {
--
2.25.1
- [PATCH 00/18] vhost-vDPA multiqueue, Jason Wang, 2021/06/21
- [PATCH 01/18] vhost_net: remove the meaningless assignment in vhost_net_start_one(), Jason Wang, 2021/06/21
- [PATCH 02/18] vhost: use unsigned int for nvqs, Jason Wang, 2021/06/21
- [PATCH 03/18] vhost_net: do not assume nvqs is always 2, Jason Wang, 2021/06/21
- [PATCH 04/18] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add(),
Jason Wang <=
- [PATCH 05/18] vhost-vdpa: don't cleanup twice in vhost_vdpa_add(), Jason Wang, 2021/06/21
- [PATCH 06/18] vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add(), Jason Wang, 2021/06/21