[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] linux-user: Let sigaction query SIGKILL/SIGSTOP
|
From: |
Laurent Vivier |
|
Subject: |
Re: [PATCH 1/2] linux-user: Let sigaction query SIGKILL/SIGSTOP |
|
Date: |
Sun, 20 Jun 2021 16:19:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Le 01/06/2021 à 16:55, Ilya Leoshkevich a écrit :
> The kernel allows doing this, so let's allow this in qemu as well.
> Valgrind relies on this.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> linux-user/signal.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 9016896dcd..bc3431708f 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -851,7 +851,11 @@ int do_sigaction(int sig, const struct target_sigaction
> *act,
>
> trace_signal_do_sigaction_guest(sig, TARGET_NSIG);
>
> - if (sig < 1 || sig > TARGET_NSIG || sig == TARGET_SIGKILL || sig ==
> TARGET_SIGSTOP) {
> + if (sig < 1 || sig > TARGET_NSIG) {
> + return -TARGET_EINVAL;
> + }
> +
> + if (act && (sig == TARGET_SIGKILL || sig == TARGET_SIGSTOP)) {
> return -TARGET_EINVAL;
> }
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>