qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/6] block-copy: improve comments of BlockCopyTask and Blo


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v4 3/6] block-copy: improve comments of BlockCopyTask and BlockCopyState types and functions
Date: Sat, 19 Jun 2021 21:31:19 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

19.06.2021 18:23, Vladimir Sementsov-Ogievskiy wrote:
  typedef struct BlockCopyTask {
      AioTask task;
+    /*
+     * IN parameters. Initialized in block_copy_task_create()
+     * and never changed.
+     */

That's just not true for method field :(

I think, we just need to document that @method is never accessed concurrently

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]