[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 13/27] tcg/tci: Emit setcond before brcond
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v7 13/27] tcg/tci: Emit setcond before brcond |
Date: |
Sat, 19 Jun 2021 17:50:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/1/21 5:00 PM, Richard Henderson wrote:
> The encoding planned for tci does not have enough room for
> brcond2, with 4 registers and a condition as input as well
> as the label. Resolve the condition into TCG_REG_TMP, and
> relax brcond to one register plus a label, considering the
> condition to always be reg != 0.
>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tci.c | 68 ++++++++++------------------------------
> tcg/tci/tcg-target.c.inc | 52 +++++++++++-------------------
> 2 files changed, 35 insertions(+), 85 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v7 04/27] plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb, (continued)
- [PATCH v7 04/27] plugins: Drop tcg_flags from struct qemu_plugin_dyn_cb, Richard Henderson, 2021/06/01
- [PATCH v7 07/27] tcg: Add tcg_call_func, Richard Henderson, 2021/06/01
- [PATCH v7 05/27] accel/tcg: Add tcg call flags to plugins helpers, Richard Henderson, 2021/06/01
- [PATCH v7 06/27] tcg: Store the TCGHelperInfo in the TCGOp for call, Richard Henderson, 2021/06/01
- [PATCH v7 09/27] tcg/tci: Improve tcg_target_call_clobber_regs, Richard Henderson, 2021/06/01
- [PATCH v7 10/27] tcg/tci: Move call-return regs to end of tcg_target_reg_alloc_order, Richard Henderson, 2021/06/01
- [PATCH v7 13/27] tcg/tci: Emit setcond before brcond, Richard Henderson, 2021/06/01
- Re: [PATCH v7 13/27] tcg/tci: Emit setcond before brcond,
Philippe Mathieu-Daudé <=
- [PATCH v7 15/27] tcg/tci: Change encoding to uint32_t units, Richard Henderson, 2021/06/01
- [PATCH v7 08/27] tcg: Build ffi data structures for helpers, Richard Henderson, 2021/06/01
- [PATCH v7 25/27] tcg/tci: Remove the qemu_ld/st_type macros, Richard Henderson, 2021/06/01
- [PATCH v7 22/27] tcg/tci: Implement add2, sub2, Richard Henderson, 2021/06/01