[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/9] qapi: make gen_if/gen_endif take a simple string
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v5 3/9] qapi: make gen_if/gen_endif take a simple string |
|
Date: |
Fri, 18 Jun 2021 11:41:28 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Mon, Jun 14, 2021 at 4:48 PM Markus Armbruster <armbru@redhat.com> wrote:
>
>> marcandre.lureau@redhat.com writes:
>>
>> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
>> >
>> > Instead of building prepocessor conditions from a list of string, use
>> > the result generated from QAPISchemaIfCond.cgen().
>>
>> I understand why you're doing this, but only because I know where you're
>> headed. By itself, it is not an improvement: you move C generation out
>> of common.py into schema.py. You need to explain why that's useful.
>>
>>
> What about?
>
> In the following commits, QAPISchemaIfCond is going to hold an internal
> tree structure. Moving cgen() there allows to abstract away the condition
> representation.
Yes, that's better.
[...]
[PATCH v5 4/9] qapi: start building an 'if' predicate tree, marcandre . lureau, 2021/06/08
[PATCH v5 5/9] qapi: introduce IfPredicateList and IfAny, marcandre . lureau, 2021/06/08
[PATCH v5 6/9] qapi: add IfNot, marcandre . lureau, 2021/06/08
[PATCH v5 7/9] qapi: normalize 'if' condition to IfPredicate tree, marcandre . lureau, 2021/06/08
[PATCH v5 8/9] qapi: convert 'if' C-expressions to the new syntax tree, marcandre . lureau, 2021/06/08
[PATCH v5 9/9] qapi: make 'if' condition strings simple identifiers, marcandre . lureau, 2021/06/08