qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 1/4] Hexagon (target/hexagon) fix bug in fLSBNEW*


From: Thomas Huth
Subject: Re: [PULL 1/4] Hexagon (target/hexagon) fix bug in fLSBNEW*
Date: Fri, 18 Jun 2021 09:08:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0

On 17/06/2021 23.52, Taylor Simpson wrote:
Change fLSBNEW/fLSBNEW0/fLSBNEW1 from copy to "x & 1"
Remove gen_logical_not function
Clean up fLSBNEWNOT to use andi-1 followed by xori-1

Test cases added to tests/tcg/hexagon/misc.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
  target/hexagon/macros.h    | 27 ++++++++++-----------------
  target/hexagon/op_helper.c |  5 -----
  tests/tcg/hexagon/misc.c   | 39 ++++++++++++++++++++++++++++++++++++++-
  3 files changed, 48 insertions(+), 23 deletions(-)

 Hi!

Looks like you've missed to add a cover letter with the PULL information to this series (at least I did not receive one and the archive on https://lists.gnu.org/archive/html/qemu-devel/2021-06/threads.html doesn't show it either)... I guess Peter won't be able to process this PULL request that way, so please send again with a proper cover letter added.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]