[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/nvme: fix pin-based interrupt behavior (again)
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH] hw/nvme: fix pin-based interrupt behavior (again) |
|
Date: |
Thu, 17 Jun 2021 07:50:19 -0700 |
On Thu, Jun 17, 2021 at 12:08:20PM +0200, Klaus Jensen wrote:
> if (cq->tail != cq->head) {
> + if (!pending) {
> + n->cq_pending++;
> + }
You should check cq->irq_enabled before incrementing cq_pending. You
don't want to leave the irq asserted when polled queues have outsanding
CQEs.