[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 0/7] support dirtyrate at the granualrity of vcpu
From: |
no-reply |
Subject: |
Re: [PATCH v6 0/7] support dirtyrate at the granualrity of vcpu |
Date: |
Thu, 17 Jun 2021 06:36:48 -0700 (PDT) |
Patchew URL:
cover.1623935540.git.huangy81@chinatelecom.cn/">https://patchew.org/QEMU/cover.1623935540.git.huangy81@chinatelecom.cn/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: cover.1623935540.git.huangy81@chinatelecom.cn
Subject: [PATCH v6 0/7] support dirtyrate at the granualrity of vcpu
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/cover.1623935540.git.huangy81@chinatelecom.cn ->
patchew/cover.1623935540.git.huangy81@chinatelecom.cn
Switched to a new branch 'test'
505b8c9 migration/dirtyrate: implement dirty-ring dirtyrate calculation
fcd9a46 migration/dirtyrate: move init step of calculation to main thread
37cf9a1 migration/dirtyrate: adjust order of registering thread
8b39c90 migration/dirtyrate: introduce struct and adjust DirtyRateStat
8f35a922 memory: make global_dirty_tracking a bitmask
baf82d4 memory: rename global_dirty_log to global_dirty_tracking
8c904aa KVM: introduce dirty_pages and kvm_dirty_ring_enabled
=== OUTPUT BEGIN ===
1/7 Checking commit 8c904aa476d5 (KVM: introduce dirty_pages and
kvm_dirty_ring_enabled)
2/7 Checking commit baf82d482e40 (memory: rename global_dirty_log to
global_dirty_tracking)
3/7 Checking commit 8f35a922eca9 (memory: make global_dirty_tracking a bitmask)
4/7 Checking commit 8b39c90b3ffe (migration/dirtyrate: introduce struct and
adjust DirtyRateStat)
5/7 Checking commit 37cf9a13595f (migration/dirtyrate: adjust order of
registering thread)
6/7 Checking commit fcd9a4690842 (migration/dirtyrate: move init step of
calculation to main thread)
7/7 Checking commit 505b8c99a555 (migration/dirtyrate: implement dirty-ring
dirtyrate calculation)
ERROR: trailing whitespace
#88: FILE: migration/dirtyrate.c:93:
+ $
WARNING: line over 80 characters
#94: FILE: migration/dirtyrate.c:99:
+ /* set sample_pages with 0 to indicate page sampling isn't enabled
*/
ERROR: trailing whitespace
#106: FILE: migration/dirtyrate.c:111:
+ $
ERROR: trailing whitespace
#325: FILE: migration/dirtyrate.c:658:
+ qapi_free_DirtyRateVcpuList(info->vcpu_dirty_rate); $
total: 3 errors, 1 warnings, 350 lines checked
Patch 7/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
cover.1623935540.git.huangy81@chinatelecom.cn/testing.checkpatch/?type=message">http://patchew.org/logs/cover.1623935540.git.huangy81@chinatelecom.cn/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH v6 0/7] support dirtyrate at the granualrity of vcpu, huangy81, 2021/06/17
- [PATCH v6 1/7] KVM: introduce dirty_pages and kvm_dirty_ring_enabled, huangy81, 2021/06/17
- [PATCH v6 2/7] memory: rename global_dirty_log to global_dirty_tracking, huangy81, 2021/06/17
- [PATCH v6 3/7] memory: make global_dirty_tracking a bitmask, huangy81, 2021/06/17
- [PATCH v6 4/7] migration/dirtyrate: introduce struct and adjust DirtyRateStat, huangy81, 2021/06/17
- [PATCH v6 5/7] migration/dirtyrate: adjust order of registering thread, huangy81, 2021/06/17
- [PATCH v6 6/7] migration/dirtyrate: move init step of calculation to main thread, huangy81, 2021/06/17
- [PATCH v6 7/7] migration/dirtyrate: implement dirty-ring dirtyrate calculation, huangy81, 2021/06/17
- Re: [PATCH v6 0/7] support dirtyrate at the granualrity of vcpu,
no-reply <=