Re: [PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors()

[Paolo Bonzini]

On 03/06/21 20:52, Richard Henderson wrote:
> On 6/3/21 10:12 AM, Peter Maydell wrote:
> > +softmmu_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c', 
> > 'aml-build-stub.c', 'ghes-stub.c'))
> >   softmmu_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss)
> >   softmmu_ss.add(when: 'CONFIG_ALL', if_true: files('acpi-stub.c', 
> > 'aml-build-stub.c',
> > -                                                  'acpi-x86-stub.c', 
> > 'ipmi-stub.c'))
> > +                                                  'acpi-x86-stub.c', 
> > 'ipmi-stub.c', 'ghes-stub.c'))
>
> Gosh that last line is confusing.  I see it's documented in 
> build-system.rst, but yeesh.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Yeah, it's vestigial of the makefiles and I should remove it.

That said, here:

> +acpi_ss.add(when: 'CONFIG_ACPI_APEI', if_true: files('ghes.c'), 
> if_false:('ghes-stub.c'))

There's a missing "files" after if_false.

Paolo