Re: [PATCH v2 22/23] hw/acpi/Kconfig: Add missing Kconfig dependencies (build error)

[Gerd Hoffmann]

On Wed, Jun 16, 2021 at 10:43:27PM +0200, Philippe Mathieu-Daudé wrote:
> The 'microvm' machine misses various dependencies:
> 
>   /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in 
> function `acpi_setup_microvm':
>   hw/i386/acpi-microvm.c:247: undefined reference to `acpi_build_tables_init'
>   /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in 
> function `acpi_build_microvm':
>   hw/i386/acpi-microvm.c:192: undefined reference to 
> `bios_linker_loader_alloc'
>   /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in 
> function `build_dsdt_microvm':
>   hw/i386/acpi-microvm.c:121: undefined reference to `init_aml_allocator'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:124: undefined reference to 
> `acpi_data_push'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:126: undefined reference to `aml_scope'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:129: undefined reference to 
> `build_ged_aml'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:131: undefined reference to 
> `acpi_dsdt_add_power_button'
>   /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in 
> function `acpi_dsdt_add_virtio':
>   hw/i386/acpi-microvm.c:77: undefined reference to `aml_string'
>   /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in 
> function `build_dsdt_microvm':
>   hw/i386/acpi-microvm.c:138: undefined reference to `aml_scope'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:149: undefined reference to 
> `build_header'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:152: undefined reference to 
> `free_aml_allocator'
>   /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in 
> function `acpi_build_microvm':
>   hw/i386/acpi-microvm.c:202: undefined reference to `acpi_add_table'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:203: undefined reference to `build_fadt'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:206: undefined reference to 
> `acpi_add_table'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:207: undefined reference to 
> `acpi_build_madt'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:212: undefined reference to `build_xsdt'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:224: undefined reference to `build_rsdp'
>   /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in 
> function `acpi_setup_microvm':
>   hw/i386/acpi-microvm.c:251: undefined reference to `acpi_add_rom_blob'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:253: undefined reference to 
> `acpi_add_rom_blob'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:255: undefined reference to 
> `acpi_add_rom_blob'
>   /usr/bin/ld: hw/i386/acpi-microvm.c:258: undefined reference to 
> `acpi_build_tables_cleanup'
>   /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in 
> function `acpi_dsdt_add_pci':
>   hw/i386/acpi-microvm.c:105: undefined reference to `acpi_dsdt_add_gpex'
>   collect2: error: ld returned 1 exit status
>   ninja: build stopped: subcommand failed.
> 
> Update the ACPI_HW_REDUCED symbol to select ACPI_MEMORY_HOTPLUG /
> ACPI_NVDIMM / ACPI.
> 
> Fixes: 8045df14bcc ("microvm/acpi: add minimal acpi support")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>