[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp
|
From: |
Taylor Simpson |
|
Subject: |
RE: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp |
|
Date: |
Wed, 16 Jun 2021 21:37:07 +0000 |
> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Wednesday, June 16, 2021 9:51 AM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: laurent@vivier.eu; alex.bennee@linaro.org
> Subject: Re: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp
>
> On 6/16/21 8:05 AM, Richard Henderson wrote:
> > On 6/16/21 1:07 AM, Taylor Simpson wrote:
> >>> + /*
> >>> + * The on-stack signal trampoline is no longer executed;
> >>> + * however, the libgcc signal frame unwinding code checks
> >>> + * for the presence of these two numeric magic values.
> >>> + */
> >>
> >> Hexagon uses musl, not libgcc. So, I'm not sure if this is needed.
> >> The signals.c test passes for me without this change. Are you seeing it
> fail?
> >
> > I copied the comment from the kernel source.
>
> Also, I think you're confusing libc and libgcc.
Yes, I'm confused. Why is signal frame unwinding in libgcc?
Also FWIW, we use LLVM's compiler-rt instead of libgcc.
[PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 10/21] linux-user/m68k: Implement setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 11/21] linux-user/microblaze: Implement setup_sigtramp, Richard Henderson, 2021/06/15
[PATCH 06/21] linux-user/cris: Implement setup_sigtramp, Richard Henderson, 2021/06/15