Re: [PATCH v2] alpha: Provide a PCI-ISA bridge device node for guest OS's that expect one

[Philippe Mathieu-Daudé]

On 6/16/21 6:53 PM, Richard Henderson wrote:
> On 6/16/21 7:15 AM, Jason Thorpe wrote:
>> - Move initialization of the ISA bus from typhoon_init() to
>> clipper_init();
>>    this apsect of device topology is really associated with the
>> individual
>>    model, not the core logic chipset.  typhoon_init() now returns the IRQ
>>    to use for the output of the ISA PIC.
>>
>> - In clipper_init(), instantiate an i82378 instance, and connect its
>>    PIC output to the ISA IRQ input provided by typhoon_init().  Remove
>>    the explicit instantiations of i8254 and i82374, as these devices
>>    are subsumed by the i82378.
>>
>> Signed-off-by: Jason Thorpe <thorpej@me.com>
>> ---
>>   hw/alpha/Kconfig     |  1 +
>>   hw/alpha/alpha_sys.h |  2 +-
>>   hw/alpha/dp264.c     | 36 ++++++++++++++++++++++++++++++------
>>   hw/alpha/typhoon.c   | 19 ++++---------------
>>   4 files changed, 36 insertions(+), 22 deletions(-)
>>
>> diff --git a/hw/alpha/Kconfig b/hw/alpha/Kconfig
>> index 15c59ff264..e907a052c3 100644
>> --- a/hw/alpha/Kconfig
>> +++ b/hw/alpha/Kconfig
>> @@ -4,6 +4,7 @@ config DP264
>>       imply TEST_DEVICES
>>       imply E1000_PCI
>>       select I82374
>> +    select I82378
>>       select I8254
>>       select I8259
>>       select IDE_CMD646
> 
> Looks good.  I removed the direct dependencies on I82374, I8254, I8259,
> which are now handled by the Kconfig entry for I82378, and the includes
> for them.

Correct, thanks.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>