[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] tests: migration-test: Still run the rest even if uff
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v2 1/2] tests: migration-test: Still run the rest even if uffd missing |
|
Date: |
Wed, 16 Jun 2021 14:49:42 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Peter Xu <peterx@redhat.com> wrote:
> Currently we'll skip the whole migration-test if uffd missing.
>
> It's a bit harsh - we can still run the rest besides postcopy! Enable them
> when we still can.
>
> It'll happen more frequently now after kernel UFFD_USER_MODE_ONLY introduced
> in
> commit 37cd0575b8510159, as qemu test normally requires kernel faults. One
> alternative is we disable kvm and create the uffd with UFFD_USER_MODE_ONLY for
> all postcopy tests, however to be simple for now just skip postcopy tests only
> by default. If we wanna run them use "sudo" or root, they'll still work. In
> all cases, it's still better than running nothing for migration-test.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
A shame we can't check postcopy without being run.