[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qapi: Fix crash on missing enum member name
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] qapi: Fix crash on missing enum member name |
|
Date: |
Wed, 16 Jun 2021 07:25:34 -0500 |
|
User-agent: |
NeoMutt/20210205 |
On Wed, Jun 16, 2021 at 09:21:21AM +0200, Markus Armbruster wrote:
> New test case enum-dict-no-name.json crashes:
>
> $ python3 scripts/qapi-gen.py tests/qapi-schema/enum-dict-no-name.json
> Traceback (most recent call last):
> [...]
> File "/work/armbru/qemu/scripts/qapi/expr.py", line 458, in check_enum
> member_name = member['name']
> KeyError: 'name'
>
> Root cause: we try to retrieve member 'name' before we check for
> missing members. With that fixed, we get the expected error "'data'
> member misses key 'name'".
>
> Fixes: 0825f62c842f2c07c5471391c6d7fd3f4fe83732
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org