Re: [PATCH] tests/vm/freebsd: Increase code coverage

[Warner Losh]

> On Jun 15, 2021, at 2:09 PM, Warner Losh <wlosh@bsdimp.com> wrote:
> 
> 
> 
>> On Jun 15, 2021, at 10:55 AM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>> 
>> On 5/31/21 10:53 PM, Wainer dos Santos Moschetta wrote:
>>> Hi,
>>> 
>>> On 5/31/21 7:03 AM, Philippe Mathieu-Daudé wrote:
>>>> Install more dependencies to increase code coverage.
>>>> 
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>>  tests/vm/freebsd | 5 +++++
>>>>  1 file changed, 5 insertions(+)
>>> 
>>> With or without this patch I got an error when `make vm-build-freebsd`.
>>> It fails to install packages.
>>> 
>>> For example, with this patch I got:
>>> 
>>> < Output omitted>
>>> 
>>> ### Installing packages ...
>>> Failed to prepare guest environment
>>> Traceback (most recent call last):
>>>  File "/home/wmoschet/src/qemu/tests/vm/basevm.py", line 634, in main
>>>    return vm.build_image(args.image)
>>>  File "/home/wmoschet/src/qemu/tests/vm/freebsd", line 206, in build_image
>>>    self.ssh_root_check("pkg install -y %s\n" % " ".join(self.pkgs))
>>>  File "/home/wmoschet/src/qemu/tests/vm/basevm.py", line 255, in
>>> ssh_root_check
>>>    self._ssh_do(self._config["root_user"], cmd, True)
>>>  File "/home/wmoschet/src/qemu/tests/vm/basevm.py", line 242, in _ssh_do
>>>    raise Exception("SSH command failed: %s" % cmd)
>>> Exception: SSH command failed: pkg install -y git pkgconf bzip2 python37
>>> ninja bash gmake gsed gettext cyrus-sasl gnutls nettle jpeg-turbo png
>>> sdl2 gtk3 libxkbcommon pixman libepoxy mesa-libs zstd usbredir
>>> 
>>> Is it a known issue?
>> 
>> I'll defer that to Warner, I suppose the package repository got updated
>> and I am not hitting that because my VM installed them earlier? (Similar
>> to the problems with Docker packages). Is there a way to use a snapshot
>> mirror of FreeBSD packages?
> 
> I’m still trying to replicate this, but I do know FreeBSD’s packages moved
> from python 3.7 to 3.8 by default recently….

It’s not this… I’m seeing inability to pull from the pkg repo, I think, as the 
root cause… Still unclear why… Sometimes it dies part way into the download. 
I’ve not yet worked out why it gets to different spots different times.

Warner

signature.asc
Description: Message signed with OpenPGP