[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/33] esp: only assert INTR_DC interrupt flag if selection fails
From: |
Paolo Bonzini |
Subject: |
[PULL 06/33] esp: only assert INTR_DC interrupt flag if selection fails |
Date: |
Tue, 15 Jun 2021 15:38:28 +0200 |
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
The datasheet sequence tables confirm that when a target selection fails, only
the INTR_DC interrupt flag should be asserted.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fixes: cf47a41e05 ("esp: latch individual bits in ESP_RINTR register")
Message-Id: <20210518212511.21688-2-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/esp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
index b668acef82..000e45a624 100644
--- a/hw/scsi/esp.c
+++ b/hw/scsi/esp.c
@@ -213,7 +213,7 @@ static int esp_select(ESPState *s)
if (!s->current_dev) {
/* No such drive */
s->rregs[ESP_RSTAT] = 0;
- s->rregs[ESP_RINTR] |= INTR_DC;
+ s->rregs[ESP_RINTR] = INTR_DC;
s->rregs[ESP_RSEQ] = SEQ_0;
esp_raise_irq(s);
return -1;
--
2.31.1
- [PULL 00/33] Misc patches for 2021-06-15, Paolo Bonzini, 2021/06/15
- [PULL 01/33] vnc: avoid deprecation warnings for SASL on OS X, Paolo Bonzini, 2021/06/15
- [PULL 05/33] runstate: Initialize Error * to NULL, Paolo Bonzini, 2021/06/15
- [PULL 06/33] esp: only assert INTR_DC interrupt flag if selection fails,
Paolo Bonzini <=
- [PULL 02/33] vl: Fix an assert failure in error path, Paolo Bonzini, 2021/06/15
- [PULL 07/33] esp: only set ESP_RSEQ at the start of the select sequence, Paolo Bonzini, 2021/06/15
- [PULL 13/33] esp: fix migration version check in esp_is_version_5(), Paolo Bonzini, 2021/06/15
- [PULL 08/33] esp: allow non-DMA callback in esp_transfer_data() initial transfer, Paolo Bonzini, 2021/06/15
- [PULL 10/33] esp: ensure PDMA write transfers are flushed from the FIFO to the target immediately, Paolo Bonzini, 2021/06/15
- [PULL 16/33] softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory, Paolo Bonzini, 2021/06/15
- [PULL 11/33] esp: revert 75ef849696 "esp: correctly fill bus id with requested lun", Paolo Bonzini, 2021/06/15
- [PULL 04/33] block/scsi: correctly emulate the VPD block limits page, Paolo Bonzini, 2021/06/15
- [PULL 15/33] softmmu/physmem: Mark shared anonymous memory RAM_SHARED, Paolo Bonzini, 2021/06/15
- [PULL 17/33] softmmu/physmem: Fix qemu_ram_remap() to handle shared anonymous memory, Paolo Bonzini, 2021/06/15