|
From: | Bruno Piazera Larsen |
Subject: | Re: [PATCH v2 1/2] target/ppc: fix address translation bug for radix mmus |
Date: | Tue, 15 Jun 2021 09:25:06 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 6/14/21 6:41 PM, David Gibson wrote:yeah, I agree that I should change the documentation. Before I send a new version with everything corrected, I wanna make sure if I should leave them in internal and use it for hash32 and 6xx MMUs, or do I put them in mmu-book3s-v3.h, since only radix64 has that the bug?
I think move these to mmu-book3s-v3.h, since they're correct for both
the radix and hash sides of the modern book3s mmu.
They're also correct for all non-booke mmus, e.g. hash32 and 6xx, which is why I recommended internal.h (or some new mmu-internal.h).
While neither hash32 nor 6xx have HV, and thus there is no second tlb bug, it would still be More Correct to use mmu_idx instead of direct references to msr_pr et al.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |