qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segme


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments
Date: Tue, 15 Jun 2021 11:54:02 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

11.06.2021 22:03, Eric Blake wrote:
To save the user from having to check 'qemu-img info --backing-chain'
or other followup command to determine which "depth":n goes beyond the
chain, add a boolean field "backing" that is set only for unallocated
portions of the disk.

Signed-off-by: Eric Blake<eblake@redhat.com>
---

Touches the same iotest output as 1/1.  If we decide that switching to
"depth":n+1 is too risky, and that the mere addition of "backing":true
while keeping "depth":n is good enough, then we'd have just one patch,
instead of this double churn.  Preferences?

If change something, this one patch seems safer. Still, Nir said he don't use 
qemu-img map, so probably we don't need to modify qemu-img at all? Even our 
iotests change shows that this change may be incompatible with at least tests..

I'm not against the patch and don't have strict opinion.

And what I really think, is that qemu-img is outdated thing and we'd better 
develop QMP interface, which can be used with qemu binary or with 
qemu-storage-daemon.

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]