Re: [PATCH] hw/nvme: be more careful when deasserting IRQs

[no-reply]

Patchew URL: 
20210610114624.304681-1-jakub.jermar@kernkonzept.com/">https://patchew.org/QEMU/20210610114624.304681-1-jakub.jermar@kernkonzept.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210610114624.304681-1-jakub.jermar@kernkonzept.com
Subject: [PATCH] hw/nvme: be more careful when deasserting IRQs

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210610132505.5827-1-peter.maydell@linaro.org -> 
patchew/20210610132505.5827-1-peter.maydell@linaro.org
 * [new tag]         
patchew/20210614135429.56475-1-jakub.jermar@kernkonzept.com -> 
patchew/20210614135429.56475-1-jakub.jermar@kernkonzept.com
Switched to a new branch 'test'
aacc285 hw/nvme: be more careful when deasserting IRQs

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#34: FILE: hw/nvme/ctrl.c:485:
+        if (q && q->vector == cq->vector && q->head != q->tail)
[...]

total: 1 errors, 0 warnings, 39 lines checked

Commit aacc285402f0 (hw/nvme: be more careful when deasserting IRQs) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210610114624.304681-1-jakub.jermar@kernkonzept.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210610114624.304681-1-jakub.jermar@kernkonzept.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com