qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/8] configure: Change to -std=gnu11


From: Paolo Bonzini
Subject: Re: [PATCH 0/8] configure: Change to -std=gnu11
Date: Mon, 14 Jun 2021 13:15:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

On 12/06/21 01:33, Richard Henderson wrote:
Now that we assume gcc 7.5 as a minimum, we have the option
of changing to a newer C standard.  The two major ones that
I think apply are _Generic and _Static_assert.

While Paolo created a remarkably functional replacement for _Generic
using builtins, the error messages that you get out of the keyword
are*vastly*  more intelligable, and the syntax is easier to read.

While I'd like to prefer _Static_assert over QEMU_BUILD_BUG_ON
going forward, and would like to convert existing uses, that is
a much bigger job.  Especially since the test condition is inverted.
In the meantime, can drop the configure detection.


Looks good, thanks. QEMU_GENERIC is the kind of thing that one can be both proud and ashamed of. :)

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]