[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/34] tcg: Remove error return from tcg_region_initial_alloc__loc
From: |
Richard Henderson |
Subject: |
[PULL 04/34] tcg: Remove error return from tcg_region_initial_alloc__locked |
Date: |
Fri, 11 Jun 2021 16:41:14 -0700 |
All callers immediately assert on error, so move the assert
into the function itself.
Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tcg.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 1e683b80e4..ba690e0483 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -720,9 +720,10 @@ static bool tcg_region_alloc(TCGContext *s)
* Perform a context's first region allocation.
* This function does _not_ increment region.agg_size_full.
*/
-static inline bool tcg_region_initial_alloc__locked(TCGContext *s)
+static void tcg_region_initial_alloc__locked(TCGContext *s)
{
- return tcg_region_alloc__locked(s);
+ bool err = tcg_region_alloc__locked(s);
+ g_assert(!err);
}
/* Call from a safe-work context */
@@ -737,9 +738,7 @@ void tcg_region_reset_all(void)
for (i = 0; i < n_ctxs; i++) {
TCGContext *s = qatomic_read(&tcg_ctxs[i]);
- bool err = tcg_region_initial_alloc__locked(s);
-
- g_assert(!err);
+ tcg_region_initial_alloc__locked(s);
}
qemu_mutex_unlock(®ion.lock);
@@ -876,11 +875,7 @@ void tcg_region_init(void)
/* In user-mode we support only one ctx, so do the initial allocation now
*/
#ifdef CONFIG_USER_ONLY
- {
- bool err = tcg_region_initial_alloc__locked(tcg_ctx);
-
- g_assert(!err);
- }
+ tcg_region_initial_alloc__locked(tcg_ctx);
#endif
}
@@ -942,7 +937,6 @@ void tcg_register_thread(void)
MachineState *ms = MACHINE(qdev_get_machine());
TCGContext *s = g_malloc(sizeof(*s));
unsigned int i, n;
- bool err;
*s = tcg_init_ctx;
@@ -966,8 +960,7 @@ void tcg_register_thread(void)
tcg_ctx = s;
qemu_mutex_lock(®ion.lock);
- err = tcg_region_initial_alloc__locked(tcg_ctx);
- g_assert(!err);
+ tcg_region_initial_alloc__locked(s);
qemu_mutex_unlock(®ion.lock);
}
#endif /* !CONFIG_USER_ONLY */
--
2.25.1
- [PULL 00/34] tcg patch queue, Richard Henderson, 2021/06/11
- [PULL 01/34] meson: Split out tcg/meson.build, Richard Henderson, 2021/06/11
- [PULL 05/34] tcg: Split out tcg_region_initial_alloc, Richard Henderson, 2021/06/11
- [PULL 06/34] tcg: Split out tcg_region_prologue_set, Richard Henderson, 2021/06/11
- [PULL 02/34] meson: Split out fpu/meson.build, Richard Henderson, 2021/06/11
- [PULL 04/34] tcg: Remove error return from tcg_region_initial_alloc__locked,
Richard Henderson <=
- [PULL 10/34] accel/tcg: Rename tcg_init to tcg_init_machine, Richard Henderson, 2021/06/11
- [PULL 03/34] tcg: Re-order tcg_region_init vs tcg_prologue_init, Richard Henderson, 2021/06/11
- [PULL 08/34] accel/tcg: Inline cpu_gen_init, Richard Henderson, 2021/06/11
- [PULL 11/34] tcg: Create tcg_init, Richard Henderson, 2021/06/11
- [PULL 07/34] tcg: Split out region.c, Richard Henderson, 2021/06/11
- [PULL 09/34] accel/tcg: Move alloc_code_gen_buffer to tcg/region.c, Richard Henderson, 2021/06/11
- [PULL 15/34] tcg: Introduce tcg_max_ctxs, Richard Henderson, 2021/06/11
- [PULL 14/34] accel/tcg: Pass down max_cpus to tcg_init, Richard Henderson, 2021/06/11
- [PULL 12/34] accel/tcg: Merge tcg_exec_init into tcg_init_machine, Richard Henderson, 2021/06/11