[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/12] Add a function named packet_new_nocopy for COLO.
From: |
Jason Wang |
Subject: |
[PULL 10/12] Add a function named packet_new_nocopy for COLO. |
Date: |
Fri, 11 Jun 2021 14:00:22 +0800 |
From: "Rao, Lei" <lei.rao@intel.com>
Use the packet_new_nocopy instead of packet_new in the
filter-rewriter module. There will be one less memory
copy in the processing of each network packet.
Signed-off-by: Lei Rao <lei.rao@intel.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/colo.c | 25 +++++++++++++++++--------
net/colo.h | 1 +
net/filter-rewriter.c | 3 +--
3 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/net/colo.c b/net/colo.c
index ef00609..3a3e6e8 100644
--- a/net/colo.c
+++ b/net/colo.c
@@ -157,19 +157,28 @@ void connection_destroy(void *opaque)
Packet *packet_new(const void *data, int size, int vnet_hdr_len)
{
- Packet *pkt = g_slice_new(Packet);
+ Packet *pkt = g_slice_new0(Packet);
pkt->data = g_memdup(data, size);
pkt->size = size;
pkt->creation_ms = qemu_clock_get_ms(QEMU_CLOCK_HOST);
pkt->vnet_hdr_len = vnet_hdr_len;
- pkt->tcp_seq = 0;
- pkt->tcp_ack = 0;
- pkt->seq_end = 0;
- pkt->header_size = 0;
- pkt->payload_size = 0;
- pkt->offset = 0;
- pkt->flags = 0;
+
+ return pkt;
+}
+
+/*
+ * packet_new_nocopy will not copy data, so the caller can't release
+ * the data. And it will be released in packet_destroy.
+ */
+Packet *packet_new_nocopy(void *data, int size, int vnet_hdr_len)
+{
+ Packet *pkt = g_slice_new0(Packet);
+
+ pkt->data = data;
+ pkt->size = size;
+ pkt->creation_ms = qemu_clock_get_ms(QEMU_CLOCK_HOST);
+ pkt->vnet_hdr_len = vnet_hdr_len;
return pkt;
}
diff --git a/net/colo.h b/net/colo.h
index 573ab91..d91cd24 100644
--- a/net/colo.h
+++ b/net/colo.h
@@ -101,6 +101,7 @@ bool connection_has_tracked(GHashTable
*connection_track_table,
ConnectionKey *key);
void connection_hashtable_reset(GHashTable *connection_track_table);
Packet *packet_new(const void *data, int size, int vnet_hdr_len);
+Packet *packet_new_nocopy(void *data, int size, int vnet_hdr_len);
void packet_destroy(void *opaque, void *user_data);
void packet_destroy_partial(void *opaque, void *user_data);
diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
index 10fe393..cb3a96c 100644
--- a/net/filter-rewriter.c
+++ b/net/filter-rewriter.c
@@ -270,8 +270,7 @@ static ssize_t colo_rewriter_receive_iov(NetFilterState *nf,
vnet_hdr_len = nf->netdev->vnet_hdr_len;
}
- pkt = packet_new(buf, size, vnet_hdr_len);
- g_free(buf);
+ pkt = packet_new_nocopy(buf, size, vnet_hdr_len);
/*
* if we get tcp packet
--
2.7.4
- [PULL 00/12] Net patches, Jason Wang, 2021/06/11
- [PULL 01/12] vhost-vdpa: skip ram device from the IOTLB mapping, Jason Wang, 2021/06/11
- [PULL 03/12] vhost-vdpa: don't initialize backend_features, Jason Wang, 2021/06/11
- [PULL 02/12] vhost-vdpa: map virtqueue notification area if possible, Jason Wang, 2021/06/11
- [PULL 04/12] vhost-vdpa: remove the unused vhost_vdpa_get_acked_features(), Jason Wang, 2021/06/11
- [PULL 05/12] netdev: add more commands to preconfig mode, Jason Wang, 2021/06/11
- [PULL 07/12] Fix the qemu crash when guest shutdown during checkpoint, Jason Wang, 2021/06/11
- [PULL 08/12] Optimize the function of filter_send, Jason Wang, 2021/06/11
- [PULL 09/12] Remove migrate_set_block_enabled in checkpoint, Jason Wang, 2021/06/11
- [PULL 06/12] Remove some duplicate trace code., Jason Wang, 2021/06/11
- [PULL 10/12] Add a function named packet_new_nocopy for COLO.,
Jason Wang <=
- [PULL 12/12] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info(), Jason Wang, 2021/06/11
- [PULL 11/12] Add the function of colo_compare_cleanup, Jason Wang, 2021/06/11
- Re: [PULL 00/12] Net patches, Peter Maydell, 2021/06/11
- Re: [PULL 00/12] Net patches, no-reply, 2021/06/14