[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/11] target/i386/sev: Remove sev_get_me_mask()
From: |
Connor Kuehl |
Subject: |
Re: [PATCH 06/11] target/i386/sev: Remove sev_get_me_mask() |
Date: |
Thu, 10 Jun 2021 09:52:49 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/10/21 1:45 AM, Philippe Mathieu-Daudé wrote:
> -uint64_t
> -sev_get_me_mask(void)
> -{
> - return sev_guest ? sev_guest->me_mask : ~0;
> -}
> -
> uint32_t
> sev_get_cbit_position(void)
> {
> @@ -810,8 +803,6 @@ int sev_kvm_init(ConfidentialGuestSupport *cgs, Error
> **errp)
> goto err;
> }
>
> - sev->me_mask = ~(1UL << sev->cbitpos);
> -
> devname = object_property_get_str(OBJECT(sev), "sev-device", NULL);
> sev->sev_fd = open(devname, O_RDWR);
> if (sev->sev_fd < 0) {
>
Brijesh, do you remember if this was added with the intent that it would
be useful in a future series?
Otherwise:
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
- [PATCH 03/11] target/i386/monitor: Return QMP error when SEV is disabled in build, (continued)
- [PATCH 03/11] target/i386/monitor: Return QMP error when SEV is disabled in build, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 04/11] target/i386/cpu: Add missing 'qapi/error.h' header, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 05/11] target/i386/sev_i386.h: Remove unused headers, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 06/11] target/i386/sev: Remove sev_get_me_mask(), Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 07/11] target/i386/sev: Mark unreachable code with g_assert_not_reached(), Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 08/11] target/i386/sev: sev_get_attestation_report use g_autofree, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 09/11] target/i386/sev: Restrict SEV to system emulation, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 10/11] target/i386/monitor: Move SEV specific commands to sev.c, Philippe Mathieu-Daudé, 2021/06/10
- [PATCH 11/11] monitor: Restrict 'info sev' to x86 targets, Philippe Mathieu-Daudé, 2021/06/10