Re: [PATCH v2 03/18] modules: add qemu-modinfo utility

[Daniel P . Berrangé]

On Thu, Jun 10, 2021 at 03:04:24PM +0200, Gerd Hoffmann wrote:
>   Hi Paolo,
> 
> > +if config_host.has_key('CONFIG_MODULES')
> > +   qemu_modinfo = executable('qemu-modinfo', files('qemu-modinfo.c') + 
> > genh,
> > +                             dependencies: [glib, qemuutil], install: 
> > have_tools)
> > +   custom_target('modinfo.json',
> > +                 input: [ softmmu_mods, block_mods ],
> > +                 output: 'modinfo.json',
> > +                 install: true,
> > +                 install_dir: qemu_moddir,
> > +                 command: [ qemu_modinfo, '.' ])
> > +endif
> 
> I have trouble with this one.  Tried to declaring the modules as "input"
> to make sure meson will only run qemu-modinfo when it is done building
> the module.  But now and then I get build errors because qemu-modinfo
> runs in parallel to a module build and qemu-modinfo throws an read error
> because of that.

softmmu_mods and block_mods are both lists already, so this sets a
nested list and I wonder if it confuses meson  ? eg do you need

 input: softmmu_mods + block_mods

Alternatively there is option to do:

  'depends: softmmu_mods + block_mods

though the meson docs claim that's not required if they're
already listed against 'input:'


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|