qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v3 20/28] tcg: Move in_code_gen_buffer and tests to region.c


From: Luis Fernando Fujita Pires
Subject: RE: [PATCH v3 20/28] tcg: Move in_code_gen_buffer and tests to region.c
Date: Wed, 9 Jun 2021 14:59:08 +0000

From: Richard Henderson <richard.henderson@linaro.org>
> Shortly, the full code_gen_buffer will only be visible to region.c, so move
> in_code_gen_buffer out-of-line.
> 
> Move the debugging versions of tcg_splitwx_to_{rx,rw} to region.c as well, so
> that the compiler gets to see the implementation of in_code_gen_buffer.
> 
> This leaves exactly one use of in_code_gen_buffer outside of region.c, in
> cpu_restore_state.  Which, being on the exception path, is not performance
> critical.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  include/tcg/tcg.h | 11 +----------
>  tcg/region.c      | 34 ++++++++++++++++++++++++++++++++++
>  tcg/tcg.c         | 23 -----------------------
>  3 files changed, 35 insertions(+), 33 deletions(-)

Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>

--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]