Re: [PATCH] configure: map x32 to cpu_family x86_64 for meson

[Daniel P . Berrangé]

On Wed, Jun 09, 2021 at 02:30:09PM +0100, Peter Maydell wrote:
> On Wed, 9 Jun 2021 at 13:48, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Wed, Jun 09, 2021 at 08:28:39AM -0400, David Michael wrote:
> > > The meson.build file defines supported_cpus which does not contain
> > > x32, and x32 is not one of meson's stable built-in values:
> > > https://mesonbuild.com/Reference-tables.html#cpu-families
> > >
> > > Signed-off-by: David Michael <fedora.dm0@gmail.com>
> > > ---
> > >
> > > Hi,
> > >
> > > QEMU fails to build for x32 due to that cpu_family not being defined in
> > > supported_cpus.  Can something like this be applied?
> > >
> > > Alternatively, maybe it could be added to supported_cpus and accepted
> > > everywhere that matches x86 in meson.build, but upstream meson does not
> > > define a CPU type for x32.
> >
> > "supported_cpus" serves two distinct purposes in meson.build
> >
> >  - Identifies whether TCG supports the target
> >  - Identifies whether QEMU maintainers consider the target supported
> >
> > The change proposed below makes x32 be treated the same as x86_64.
> 
> I feel like it's more "fixing a regression we introduced by accident
> at some point". Looking at the 5.1 configure script (which predates
> the meson conversion) x32 is marked as a supported cpu. Currently it
> isn't, so that's a regression. (I don't have the setup to bisect that
> right now, but it would be interesting to confirm where it stopped
> working.) Whether we feel that we no longer want to support x32 is
> a separate question and we'd need to go through our usual deprecation
> process if we did want to drop it.

Ah, I missed that it was previously working.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|