[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 01/13] qemu-trace-stap: changing SYSTEMTAP_TAPSET consider
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v4 01/13] qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful. |
Date: |
Wed, 9 Jun 2021 13:39:08 +0100 |
On Tue, Jun 01, 2021 at 03:24:02PM +0200, Gerd Hoffmann wrote:
> Setting SYSTEMTAP_TAPSET to some value other than
> /usr/share/systemtap/tapsets results in systemtap not finding the
> standard tapset library any more, which in turn breaks tracing because
> pid() and other standard systemtap functions are not available any more.
>
> So using SYSTEMTAP_TAPSET to point systemtap to the qemu probes will
> only work for the prefix=/usr installs because both qemu and system
> tapsets in the same directory then. All other prefixes are broken.
>
> Fix that by using the "-I $tapsetdir" command line switch instead.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> scripts/qemu-trace-stap | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- [PATCH v4 00/13] [RfC] fix tracing for modules, Gerd Hoffmann, 2021/06/01
- [PATCH v4 01/13] qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful., Gerd Hoffmann, 2021/06/01
- [PATCH v4 03/13] trace: add trace_event_iter_init_group, Gerd Hoffmann, 2021/06/01
- [PATCH v4 02/13] trace: iter init tweaks, Gerd Hoffmann, 2021/06/01
- [PATCH v4 04/13] trace/simple: pass iter to st_write_event_mapping, Gerd Hoffmann, 2021/06/01
- [PATCH v4 05/13] trace/simple: add st_init_group, Gerd Hoffmann, 2021/06/01
- [PATCH v4 06/13] meson: add trace_events_config[], Gerd Hoffmann, 2021/06/01
- [PATCH v4 07/13] meson: move up hw subdir (specifically before trace subdir), Gerd Hoffmann, 2021/06/01
- [PATCH v4 09/13] trace/stap: build stap files for modules, Gerd Hoffmann, 2021/06/01