Re: [PATCH 12/55] target/arm: Implement widening/narrowing MVE VLDR/VSTR insns

[Richard Henderson]

On 6/7/21 9:57 AM, Peter Maydell wrote:
> +#define DO_VLDST_WIDE_NARROW(OP, SLD, ULD, ST)                          \
> +    static bool trans_##OP(DisasContext *s, arg_VLDR_VSTR *a)           \
> +    {                                                                   \
> +        MVEGenLdStFn *ldfns[] = {                                       \
> +            gen_helper_mve_##SLD,                                       \
> +            gen_helper_mve_##ULD,                                       \
> +        };                                                              \
> +        MVEGenLdStFn *stfns[] = {                                       \
> +            gen_helper_mve_##ST,                                        \
> +            NULL,                                                       \
> +        };                                                              \
> +        return do_ldst(s, a, a->l ? ldfns[a->u] : stfns[a->u]);         \
> +    }

static const on the arrays, or array, as before.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~