[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/7] migration/dirtyrate: make sample page count configura
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v3 1/7] migration/dirtyrate: make sample page count configurable |
Date: |
Tue, 8 Jun 2021 20:02:37 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
* Eric Blake (eblake@redhat.com) wrote:
> On Mon, Jun 07, 2021 at 09:11:34AM +0800, huangy81@chinatelecom.cn wrote:
> > From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> >
> > introduce optional sample-pages argument in calc-dirty-rate,
> > making sample page count per GB configurable so that more
> > accurate dirtyrate can be calculated.
> >
> > Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> > ---
>
> > +++ b/qapi/migration.json
> > # Example:
> > -# {"command": "calc-dirty-rate", "data": {"calc-time": 1} }
> > +# {"command": "calc-dirty-rate", "data": {"calc-time": 1,
> > 'sample-pages': 512} }
> > #
> > ##
> > -{ 'command': 'calc-dirty-rate', 'data': {'calc-time': 'int64'} }
> > +{ 'command': 'calc-dirty-rate', 'data': {'calc-time': 'int64',
> > '*sample-pages': 'int'} }
>
> Long line. Please wrap at 80 columns.
I can fix up that.
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- Re: [PATCH v3 7/7] migration/dirtyrate: implement dirty-ring dirtyrate calculation, (continued)
- [PATCH v3 1/7] migration/dirtyrate: make sample page count configurable, huangy81, 2021/06/06
- [PATCH v3 2/7] hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds, huangy81, 2021/06/06
- [PATCH v3 5/7] migration/dirtyrate: adjust struct DirtyRateStat, huangy81, 2021/06/06
- Re: [PATCH v3 0/7] support dirtyrate at the granualrity of vcpu, Hyman, 2021/06/06
- Re: [PATCH v3 0/7] support dirtyrate at the granualrity of vcpu, no-reply, 2021/06/09