[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 8/9] i386: Hyper-V SynIC requires POST_MESSAGES/SIGNAL_EVENTS
From: |
Vitaly Kuznetsov |
Subject: |
[PATCH v8 8/9] i386: Hyper-V SynIC requires POST_MESSAGES/SIGNAL_EVENTS privileges |
Date: |
Tue, 8 Jun 2021 14:08:16 +0200 |
When Hyper-V SynIC is enabled, we may need to allow Windows guests to make
hypercalls (POST_MESSAGES/SIGNAL_EVENTS). No issue is currently observed
because KVM is very permissive, allowing these hypercalls regarding of
guest visible CPUid bits.
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
target/i386/kvm/hyperv-proto.h | 6 ++++++
target/i386/kvm/kvm.c | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/target/i386/kvm/hyperv-proto.h b/target/i386/kvm/hyperv-proto.h
index e30d64b4ade4..5fbb385cc136 100644
--- a/target/i386/kvm/hyperv-proto.h
+++ b/target/i386/kvm/hyperv-proto.h
@@ -38,6 +38,12 @@
#define HV_ACCESS_FREQUENCY_MSRS (1u << 11)
#define HV_ACCESS_REENLIGHTENMENTS_CONTROL (1u << 13)
+/*
+ * HV_CPUID_FEATURES.EBX bits
+ */
+#define HV_POST_MESSAGES (1u << 4)
+#define HV_SIGNAL_EVENTS (1u << 5)
+
/*
* HV_CPUID_FEATURES.EDX bits
*/
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 33830117fa31..260c563d59a3 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -1343,6 +1343,12 @@ static int hyperv_fill_cpuids(CPUState *cs,
/* Unconditionally required with any Hyper-V enlightenment */
c->eax |= HV_HYPERCALL_AVAILABLE;
+ /* SynIC and Vmbus devices require messages/signals hypercalls */
+ if (hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC) &&
+ !cpu->hyperv_synic_kvm_only) {
+ c->ebx |= HV_POST_MESSAGES | HV_SIGNAL_EVENTS;
+ }
+
/* Not exposed by KVM but needed to make CPU hotplug in Windows work */
c->edx |= HV_CPU_DYNAMIC_PARTITIONING_AVAILABLE;
--
2.31.1
- [PATCH v8 1/9] i386: avoid hardcoding '12' as 'hyperv_vendor_id' length, (continued)
- [PATCH v8 1/9] i386: avoid hardcoding '12' as 'hyperv_vendor_id' length, Vitaly Kuznetsov, 2021/06/08
- [PATCH v8 2/9] i386: clarify 'hv-passthrough' behavior, Vitaly Kuznetsov, 2021/06/08
- [PATCH v8 3/9] i386: hardcode supported eVMCS version to '1', Vitaly Kuznetsov, 2021/06/08
- [PATCH v8 4/9] i386: make hyperv_expand_features() return bool, Vitaly Kuznetsov, 2021/06/08
- [PATCH v8 5/9] i386: expand Hyper-V features during CPU feature expansion time, Vitaly Kuznetsov, 2021/06/08
- [PATCH v8 6/9] i386: kill off hv_cpuid_check_and_set(), Vitaly Kuznetsov, 2021/06/08
- [PATCH v8 7/9] i386: HV_HYPERCALL_AVAILABLE privilege bit is always needed, Vitaly Kuznetsov, 2021/06/08
- [PATCH v8 8/9] i386: Hyper-V SynIC requires POST_MESSAGES/SIGNAL_EVENTS privileges,
Vitaly Kuznetsov <=
- [PATCH v8 9/9] qtest/hyperv: Introduce a simple hyper-v test, Vitaly Kuznetsov, 2021/06/08