[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/28] tcg: Remove error return from tcg_region_initial_al
From: |
Alex Bennée |
Subject: |
Re: [PATCH v3 04/28] tcg: Remove error return from tcg_region_initial_alloc__locked |
Date: |
Tue, 08 Jun 2021 12:04:35 +0100 |
User-agent: |
mu4e 1.5.13; emacs 28.0.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> All callers immediately assert on error, so move the assert
> into the function itself.
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
The change itself seems reasonable although I do find the return values
of the underlying tcg_region_alloc__locked a little confusing. What we
are saying is the initial allocation should never fail but subsequent
allocations aren't actually fails but creation of new regions?
Anyway:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- Re: [PATCH v3 04/28] tcg: Remove error return from tcg_region_initial_alloc__locked,
Alex Bennée <=