Re: [PATCH v2 1/2] qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event

[Eric Blake]

On Mon, Jun 07, 2021 at 12:23:53PM +1000, David Gibson wrote:
> On Mon, Jun 07, 2021 at 12:23:08PM +1000, David Gibson wrote:
> > On Fri, Jun 04, 2021 at 05:03:52PM -0300, Daniel Henrique Barboza wrote:
> > > At this moment we only provide one event to report a hotunplug error,
> > > MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries
> > > machine is now able to report unplug errors for other device types, such
> > > as CPUs.
> > > 
> > > Instead of creating a (device_type)_UNPLUG_ERROR for each new device,
> > > create a generic DEVICE_UNPLUG_ERROR event that can be used by all
> > > unplug errors in the future.
> > > 
> > > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> > 
> > Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> 
> Markus, I'm happy to take this through my tree if that's convenient
> for you, but I'd like to get an ack.

I'm not Markus, but if you're happy with my interface review,

Reviewed-by: Eric Blake <eblake@redhat.com>


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org