[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/8] tests/tcg/configure.sh: tweak quoting of target_compiler
From: |
Alex Bennée |
Subject: |
[PULL 3/8] tests/tcg/configure.sh: tweak quoting of target_compiler |
Date: |
Mon, 7 Jun 2021 15:32:58 +0100 |
If you configure the host compiler with a multi-command stanza like:
--cc="ccache gcc"
then the configure.sh machinery falls over with confusion. Work around
this by ensuring we correctly quote so where we need a complete
evaluation we get it. Of course the has() check needs single variable
so we need to unquote that. This does mean it essentially checks that
just the ccache command exits but if we got past that step we still
check the compiler actually does something.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>
Message-Id: <20210527160319.19834-4-alex.bennee@linaro.org>
diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
index ed6492ce59..aa7c24328a 100755
--- a/tests/tcg/configure.sh
+++ b/tests/tcg/configure.sh
@@ -222,10 +222,10 @@ for target in $target_list; do
got_cross_cc=no
- if eval test "x\${cross_cc_$arch}" != xyes; then
- eval "target_compiler=\${cross_cc_$arch}"
+ if eval test "x\"\${cross_cc_$arch}\"" != xyes; then
+ eval "target_compiler=\"\${cross_cc_$arch}\""
- if has "$target_compiler"; then
+ if has $target_compiler; then
if test "$supress_clang" = yes &&
$target_compiler --version | grep -qi "clang"; then
got_cross_cc=no
--
2.20.1
- [PULL 0/8] testing and misc updates, Alex Bennée, 2021/06/07
- [PULL 6/8] gitlab-ci: Split gprof-gcov job, Alex Bennée, 2021/06/07
- [PULL 8/8] scripts/checkpatch.pl: process .c.inc and .h.inc files as C source, Alex Bennée, 2021/06/07
- [PULL 7/8] tests/vm: expose --source-path to scripts to find extra files, Alex Bennée, 2021/06/07
- Re: [PULL 0/8] testing and misc updates, Peter Maydell, 2021/06/07