Re: [PATCH] netdev: add more commands to preconfig mode

[Paolo Bonzini]

On 11/05/21 17:39, Paolo Bonzini wrote:
> Creating and destroying network backend does not require a fully
> constructed machine.  Allow the related monitor commands to run before
> machine initialization has concluded.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hmp-commands.hx | 2 ++
>   qapi/net.json   | 6 ++++--
>   2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 901a50ebd1..1768bc5df0 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1276,6 +1276,7 @@ ERST
>           .help       = "add host network device",
>           .cmd        = hmp_netdev_add,
>           .command_completion = netdev_add_completion,
> +        .flags      = "p",
>       },
>   
>   SRST
> @@ -1290,6 +1291,7 @@ ERST
>           .help       = "remove host network device",
>           .cmd        = hmp_netdev_del,
>           .command_completion = netdev_del_completion,
> +        .flags      = "p",
>       },
>   
>   SRST
> diff --git a/qapi/net.json b/qapi/net.json
> index af3f5b0fda..7fab2e7cd8 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -55,7 +55,8 @@
>   # <- { "return": {} }
>   #
>   ##
> -{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true }
> +{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true,
> +  'allow-preconfig': true }
>   
>   ##
>   # @netdev_del:
> @@ -75,7 +76,8 @@
>   # <- { "return": {} }
>   #
>   ##
> -{ 'command': 'netdev_del', 'data': {'id': 'str'} }
> +{ 'command': 'netdev_del', 'data': {'id': 'str'},
> +  'allow-preconfig': true }
>   
>   ##
>   # @NetLegacyNicOptions:

Ping.